feat(tracing): Move common tracing code to core #7166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try-javascript into feat/tracing-in-core
|
Well at least the integration tests are doing their job... |
timfish
force-pushed
the
feat/tracing-in-core
branch
from
153e898 to
43d5df0
Compare
|
Gonna take this over to try and merge! |
|
Closing this PR in favour of #7339 (same thing, but with merge conflicts fixed. Had to open a new PR since I couldn't push to fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7091
This PR:
core/src/tracing@sentry/corenow exports the same common types plus:addTracingExtensions- Required so that@sentry/tracingcan still add the extensions viaaddExtensionMethodsTRACING_DEFAULTS- This contains the timing defaults that are used across tracingaddExtensionMethodsin@sentry/tracingdue to_autoloadDatabaseIntegrations@sentry/tracingto ensure there are no breaking changes to public APIidletransaction.test.tsimports code from core soIdleTransactionSpanRecorderdoesn't need to be made publicThis PR does not:
Span,Transaction, etc from@sentry/corerather than@sentry/tracing